Open
Conversation
|
LGTM 💃 |
|
Are there any updates on bumping the dependancies? This is currently a blocker on my team, similar to #55 |
|
Hi @goto-bus-stop, is there anything I can help with to have this PR moved forward? Edit: I looked into acorn-node@1.8.2 and I see that it depends on acorn@7.0.0, which shows a vulnerability in Snyk. There's a fixed version available: acorn@7.1.1 is clean. Upstream, acorn-node@2.0.0 and acorn-node@2.0.1 are both on acorn@7.0.0. Would myself or someone else going and opening a PR for acorn-node to use acorn@7.1.1, and then having static-module use that new acorn-node build be the best course of action? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just did a blanket
npm update.Should fix #55, because acorn-node 1.8 depends on acorn 7.
Finally closes #48, because this exposes the option added in browserify/static-eval#31.